Problem with Drag&Drop with scroll
Playermet —Fri, 11/02/2012 - 15:37
Good day!
I have find some problem with Drag&Drop.
If page scrolled, destination cell determined with displacement.
I think, I find the solution to this problem.
Just replace this line in fastdial.html:
if (!isMouseOver(FdDom.get(i), e.pageX, e.pageY)) continue;
to this:
if (!isMouseOver(FdDom.get(i), e.pageX - document.body.scrollLeft, e.pageY - document.body.scrollTop)) continue;
Please, sorry for bad English.
Re: Problem with Drag&Drop with scroll
Submitted by chiaroscuro on Sat, 11/03/2012 - 16:32@Playerment I have confirmed the problem. I will work on a new .xpi with your fix when I have time.
»
Is this problem directly related to a specific version of Firefox
Re: Problem with Drag&Drop with scroll
Submitted by chiaroscuro on Sat, 11/03/2012 - 16:32@Playerment I have confirmed the problem. I will work on a new .xpi with your fix when I have time.
»
Is this problem directly related to a specific version of Firefox
Re: Problem with Drag&Drop with scroll
Submitted by Efreak15 on Sat, 11/03/2012 - 18:02Is this problem directly related to a specific version of Firefox.
No. I tested it with a lower versions also. @Playerment's video shows exactly what the problem is. Replaced some of the code courtesy of @Playerment. Here's the new version (4.3): http://ge.tt/api/1/files/4xnTisQ/0/blob?download
If you give the go ahead, I'll upload it as a new version on AMO.
Re: Problem with Drag&Drop with scroll
Submitted by chiaroscuro on Sat, 11/03/2012 - 18:06No. I tested it with a lower versions also
Ah ok..
Sounds then fine to upload
Good work getting it all together so fast... !
And thanks too to Playermet for coming up with this fix
What would we have done without him !
Re: Problem with Drag&Drop with scroll
Submitted by Efreak15 on Sat, 11/03/2012 - 18:17Sounds then fine to upload
Will do then:)
Re: Problem with Drag&Drop with scroll
Submitted by Efreak15 on Sat, 11/03/2012 - 18:32Uploaded new version with this changelog:
Changelog:
-Fixed dragging&dropping cells when scrolling in Fast Dial page.
-Bug found and fix made by Playermet. Thank you:)
Good to have a new version out. It's been 7 months since last version.
Re: Problem with Drag&Drop with scroll
Submitted by Efreak15 on Sat, 11/03/2012 - 18:56I also cleaned up the addon description and added relevant Developer Comment.
Re: Problem with Drag&Drop with scroll
Submitted by chiaroscuro on Sun, 11/04/2012 - 01:42Ef
Do you remember this thread
http://www.userlogos.org/node/15199
I think the following aspects of Fast Dial should be considered
1. To test your new fix with Fixed selected
2. To test with Fixed not selected
3 To see if pages function still works (this is directly related to scrolling)
Pages only works with Fixed not selected
The pages function allows one to have multiple pages in the root.
Re: Problem with Drag&Drop with scroll
Submitted by Efreak15 on Sun, 11/04/2012 - 16:251. To test your new fix with Fixed selected
2. To test with Fixed not selected
3 To see if pages function still works (this is directly related to scrolling)
Tried all those situations out with fix. Everything works perfectly.
Re: Problem with Drag&Drop with scroll
Submitted by chiaroscuro on Sun, 11/04/2012 - 16:43Tried all those situations out with fix. Everything works perfectly.
Good news !
Pages